Re: [PATCH] imon_raw: respect DMA coherency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Oliver,

On Tue, May 17, 2022 at 09:34:49AM +0200, Oliver Neukum wrote:
> On 16.05.22 18:40, Sean Young wrote:
> > On Mon, May 16, 2022 at 01:00:30PM +0200, Oliver Neukum wrote:
> >> On 13.05.22 18:23, Sean Young wrote:
> >> Hi!
> >>> On Thu, May 12, 2022 at 03:03:21PM +0200, Oliver Neukum wrote:
> >>>> No buffer can be embedded inside a descriptor, not even a simple be64.
> >>>> Use a separate kmalloc()
> >>> This patch needs a tiny change from be64_to_cpu() to be64_to_cpup(), I've
> >>> tested that change with the hardware.
> >> Needs? It is certainly not wrong and the subsequent logging will be in the
> >> converted order, but need
> > It certainly is wrong, and it doesn't compile without it, so yes it does
> > need it. The kernel test robot also complained about.
> >
> >
> 
> Hi,
> 
> sorry, it seems I forgot a "*". You are right.

Thank you for your patches, they fix many important issues that I missed.


Sean



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux