Hi Sakari, I -litterally- just sent a v7 to you and Mauro (and list) to fix the warning. Feel free to ignore it then On Fri, May 13, 2022 at 05:15:20PM +0300, Sakari Ailus wrote: > Hi folks, > > Reworked the internals a little so that no compile warnings are produced > for intermediate patches. In the past we've allowed them but now with > warnings considered as errors, this is a problem. > > The end result is unchanged. Still testing for compilation. > > I'm still sending this all to list as several patches got changed: > > media: ov5640: Associate bpp with formats > media: ov5640: Rework CSI-2 clock tree > media: ov5640: Split DVP and CSI-2 formats In my v7 I have only moved ov5640_code_to_bpp() from [4/28] to [6/28] where it is actually used. Hence the changed patches for me are: media: ov5640: Associate bpp with formats [4/28] media: ov5640: Update pixel_rate and link_freq [6/28] Are there other warnings to fix which I have missed ? Thanks j > > Hugues Fruchet (1): > media: ov5640: Adjust vblank with s_frame_interval > > Jacopo Mondi (27): > media: ov5640: Add pixel rate to modes > media: ov5640: Re-arrange modes definition > media: ov5640: Add ov5640_is_csi2() function > media: ov5640: Associate bpp with formats > media: ov5640: Add LINK_FREQ control > media: ov5640: Update pixel_rate and link_freq > media: ov5640: Rework CSI-2 clock tree > media: ov5640: Rework timings programming > media: ov5640: Fix 720x480 in RGB888 mode > media: ov5640: Split DVP and CSI-2 timings > media: ov5640: Provide timings accessor > media: ov5640: Re-sort per-mode register tables > media: ov5640: Remove duplicated mode settings > media: ov5640: Remove ov5640_mode_init_data > media: ov5640: Add HBLANK control > media: ov5640: Add VBLANK control > media: ov5640: Remove frame rate check from find_mode() > media: ov5640: Change CSI-2 timings to comply with FPS > media: ov5640: Implement init_cfg > media: ov5640: Implement get_selection > media: ov5640: Register device properties > media: ov5640: Add RGB565_1X16 format > media: ov5640: Add BGR888 format > media: ov5640: Restrict sizes to mbus code > media: ov5640: Adjust format to bpp in s_fmt > media: ov5640: Split DVP and CSI-2 formats > media: ov5640: Move format mux config in format > > drivers/media/i2c/ov5640.c | 1650 ++++++++++++++++++++++++++---------- > 1 file changed, 1188 insertions(+), 462 deletions(-) > > -- > 2.30.2 >