Hi Hans, Thank you for the patch. On Mon, May 09, 2022 at 11:15:48AM +0200, Hans Verkuil wrote: > Fixes smatch warning: > > drivers/media/v4l2-core/v4l2-ctrls-core.c:1143 v4l2_ctrl_handler_init_class() warn: Please consider using kvcalloc instead > > Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > drivers/media/v4l2-core/v4l2-ctrls-core.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/v4l2-core/v4l2-ctrls-core.c b/drivers/media/v4l2-core/v4l2-ctrls-core.c > index 8968cec8454e..949c1884d9c1 100644 > --- a/drivers/media/v4l2-core/v4l2-ctrls-core.c > +++ b/drivers/media/v4l2-core/v4l2-ctrls-core.c > @@ -1140,9 +1140,8 @@ int v4l2_ctrl_handler_init_class(struct v4l2_ctrl_handler *hdl, > INIT_LIST_HEAD(&hdl->ctrls); > INIT_LIST_HEAD(&hdl->ctrl_refs); > hdl->nr_of_buckets = 1 + nr_of_controls_hint / 8; > - hdl->buckets = kvmalloc_array(hdl->nr_of_buckets, > - sizeof(hdl->buckets[0]), > - GFP_KERNEL | __GFP_ZERO); > + hdl->buckets = kvcalloc(hdl->nr_of_buckets, sizeof(hdl->buckets[0]), > + GFP_KERNEL); > hdl->error = hdl->buckets ? 0 : -ENOMEM; > v4l2_ctrl_handler_init_request(hdl); > return hdl->error; -- Regards, Laurent Pinchart
