Hi Hans, Thank you for the patch. On Mon, May 09, 2022 at 11:15:49AM +0200, Hans Verkuil wrote: > Fixes smatch warning: > > drivers/media/common/videobuf2/videobuf2-dma-sg.c:129 vb2_dma_sg_alloc() warn: Please consider using kvcalloc instead > > Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > drivers/media/common/videobuf2/videobuf2-dma-sg.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/common/videobuf2/videobuf2-dma-sg.c b/drivers/media/common/videobuf2/videobuf2-dma-sg.c > index f8a21c560ad2..fa69158a65b1 100644 > --- a/drivers/media/common/videobuf2/videobuf2-dma-sg.c > +++ b/drivers/media/common/videobuf2/videobuf2-dma-sg.c > @@ -126,8 +126,7 @@ static void *vb2_dma_sg_alloc(struct vb2_buffer *vb, struct device *dev, > * there is no memory consistency guarantee, hence dma-sg ignores DMA > * attributes passed from the upper layer. > */ > - buf->pages = kvmalloc_array(buf->num_pages, sizeof(struct page *), > - GFP_KERNEL | __GFP_ZERO); > + buf->pages = kvcalloc(buf->num_pages, sizeof(struct page *), GFP_KERNEL); > if (!buf->pages) > goto fail_pages_array_alloc; > -- Regards, Laurent Pinchart
