Hi Andy On 05/05/2022 11:31, Andy Shevchenko wrote: > On Wed, May 04, 2022 at 11:30:27PM +0100, Daniel Scally wrote: >> Add a vblank control to the ov7251 driver. >> +static int ov7251_vts_configure(struct ov7251 *ov7251, s32 vblank) >> +{ >> + u8 vts[2]; >> + >> + vts[0] = ((ov7251->current_mode->height + vblank) & 0xff00) >> 8; >> + vts[1] = ((ov7251->current_mode->height + vblank) & 0x00ff); > __be16 vts; > > cpu_to_be16(); Most places that do this seem to do the conversion in the i2c read/write functions, so in this case within ov7251_write_seq_regs(). Can I do it there, as an extra patch? I actually have more changes to make on this driver but they're not remotely read yet so there'll be another series in the future >> + return ov7251_write_seq_regs(ov7251, OV7251_TIMING_VTS_REG, vts, 2); >> +}