On Wed, May 04, 2022 at 11:30:16PM +0100, Daniel Scally wrote:
> Move the endpoint checking from .probe() to a dedicated function,
> and additionally check that the firmware provided link frequencies
> are a match for those supported by the driver. Store the index to the
> matching link frequency so it can be easily identified later.
...
> + if (!bus_cfg.nr_of_link_frequencies) {
> + ret = -EINVAL;
> + dev_err_probe(ov7251->dev, ret,
> + "no link frequencies defined\n");
ret = dev_err_probe(ov7251->dev, -EINVAL,
"no link frequencies defined\n");
?
> + goto out_free_bus_cfg;
> + }
...
> + if (i == bus_cfg.nr_of_link_frequencies) {
> + ret = -EINVAL;
> + dev_err_probe(ov7251->dev, ret,
> + "no supported link freq found\n");
Ditto.
> + goto out_free_bus_cfg;
> + }
--
With Best Regards,
Andy Shevchenko
