Hi Hans,
On Do, 2022-04-28 at 09:51 +0200, Hans Verkuil wrote:
> On 26/04/2022 11:15, Philipp Zabel wrote:
> > Let VIDIOC_ENUM_FRAMEINTERVALS return -EINVAL if userspace queries
> > frame intervals for frame sizes unsupported by the encoder. Fixes the
> > following v4l2-compliance failure:
> >
> > fail: v4l2-test-formats.cpp(123): found frame intervals for invalid size 47x16
> > fail: v4l2-test-formats.cpp(282): node->codec_mask & STATEFUL_ENCODER
> > test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: FAIL
> >
> > For decoder devices, return -ENOTTY.
>
> Shouldn't that be 'encoder devices'?
>
> And why mention it at all since this isn't part of the changes in this patch?
>
> I can drop this last sentence, if you like, but before I do that I need
> confirmation that that's OK.
Yes please, thank you for catching this. It is an artifact from when I
rebased this patch past a3b9b81462a2 ("media: coda: disable encoder
ioctls for decoder devices").
regards
Philipp
