Hi Mike, Thanks for the patch. On Wed, Apr 27, 2022 at 04:20:12PM -0400, Mike Pagano wrote: > Add V4L2_FWNODE as a dependency to match other drivers and prevent > failures when compile testing. > > Signed-off-by: Mike Pagano <mpagano@xxxxxxxxxx> > --- > drivers/media/i2c/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index fae2baabb773..6168c04d8b37 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -372,6 +372,7 @@ config VIDEO_OV13B10 > config VIDEO_OV2640 > tristate "OmniVision OV2640 sensor support" > depends on VIDEO_DEV && I2C > + select V4L2_FWNODE The driver doesn't use v4l2-fwnode but seems to depend on v4l2-async. Shouldn't this be V4L2_ASYNC instead? Could you also add this tag: Fixes: ff3cc65cadb5 ("media: v4l: async, fwnode: Improve module organisation") > help > This is a Video4Linux2 sensor driver for the OmniVision > OV2640 camera. -- Kind regards, Sakari Ailus