Hi Xavier,
Thank you for the patch.
On Mon, Mar 28, 2022 at 04:13:05PM +0200, Xavier Roumegue wrote:
> Add a control base for DW100 driver controls, and reserve 16 controls.
>
> Signed-off-by: Xavier Roumegue <xavier.roumegue@xxxxxxxxxxx>
> ---
> include/uapi/linux/v4l2-controls.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h
> index bb40129446d4..9ef608a1f9ce 100644
> --- a/include/uapi/linux/v4l2-controls.h
> +++ b/include/uapi/linux/v4l2-controls.h
> @@ -218,12 +218,16 @@ enum v4l2_colorfx {
> * We reserve 16 controls for this driver.
> */
> #define V4L2_CID_USER_ALLEGRO_BASE (V4L2_CID_USER_BASE + 0x1170)
> -
That seems unrelated.
> /*
> * The base for the isl7998x driver controls.
> * We reserve 16 controls for this driver.
> */
> #define V4L2_CID_USER_ISL7998X_BASE (V4L2_CID_USER_BASE + 0x1180)
And a blank line is needed here. With this fixed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> +/*
> + * The base for DW100 driver controls.
> + * We reserve 16 controls for this driver.
> + */
> +#define V4L2_CID_USER_DW100_BASE (V4L2_CID_USER_BASE + 0x1190)
>
> /* MPEG-class control IDs */
> /* The MPEG controls are applicable to all codec controls
--
Regards,
Laurent Pinchart
