On Di, 2022-04-26 at 07:52 +0200, Hans Verkuil wrote: [...] > > > Are there still applications that rely on zero-sized output buffers to stop the > > > decoder? > > > > This was used by GStreamer 1.8. The code is still left in current > > versions, but is never executed unless the decoder stop command fails: > > > > https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/main/subprojects/gst-plugins-good/sys/v4l2/gstv4l2videodec.c#L446-454 > > > > Whether there are still any applications using GStreamer 1.8 for V4L2 > > video decoding on devices that get kernel updates, I don't know. > > > > > I'm not actually sure that I want this in the driver, perhaps v4l2-compliance > > > can be modified to turn a fail into a warn if the driver is the coda driver. > > > > Same for nxp/imx-jpeg, qcom/venus and samsung/s5p-mfc? > > Yes for venus and s5p, but why would imx-jpeg use this? > > It makes no sense for a jpeg codec. I think it should just be removed for imx-jpeg. > > IMHO, once a decoder supports the STOP command, it should no longer set > allow_zero_bytesused to true. But that decision is up to you for the coda > driver. Turns out there is no associated v4l2-compliance failure at all. I'd just drop this patch for now and keep the allow_zero_bytesused flag as-is. regards Philipp
