On Sun, Apr 24, 2022 at 09:22:30PM -0400, Ian Cowan wrote: > On Sun, Apr 24, 2022 at 09:17:22PM +0200, LABBE Corentin wrote: > > Hello > > > > Thanks for your patchs, removing dprintk is a good idea. > > Please use pci_xxx() instead of dev_xxx() to be consistent with the rest of the driver. > > The comment title is misleading, zrdev_err is not about debugging. What about Logging macros ? > > > > Regards > > > > I have made those modifications, and I will resubmit patches 1 and 2 > shortly. Those are the only patches that affected by this change; 3 and > 4 will not change. You should send a whole new series, properly versioned as the documentation in the kernel asks you to. Otherwise it is impossible for reviewers and maintainers to know what is the "latest" version to accept. thanks, greg k-h
