Re: [PATCH v3 2/2] media: i2c: imx412: Add bulk regulator support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 14, 2022 at 03:04:10PM +0100, Bryan O'Donoghue wrote:
> On 14/04/2022 14:56, Sakari Ailus wrote:
> > On Thu, Apr 14, 2022 at 02:44:00PM +0100, Bryan O'Donoghue wrote:
> > > On 14/04/2022 14:00, Sakari Ailus wrote:
> > > > >    	ret = clk_prepare_enable(imx412->inclk);
> > > > >    	if (ret) {
> > > > > +		regulator_bulk_disable(imx412->num_supplies,
> > > > > +				       imx412->supplies);
> > > > As the function already has an error handling section using labels, this
> > > > should go there as well.
> > > > 
> > > Are you asking to move regulator_bulk_disable() to error_reset ?
> > 
> > No. You'll need another label.
> > 
> 
> Hmm.
> 
> I think another label is not required, have a look at V4.

Ah, yes, indeed. There's just a single location where this will be needed.

On another note, gpiod_set_value_cansleep() seems to enable reset in
resume and disable it in suspend. I.e. the polarity is wrong.

-- 
Sakari Ailus



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux