On Wed, Apr 13, 2022 at 10:32 PM Sakari Ailus
<sakari.ailus@xxxxxxxxxxxxxxx> wrote:
>
> This reverts commit c09d776eaa060534a1663e3b89d842db3e1d9076.
>
> Revert the commit as it breaks runtime PM support on OF based systems.
> More fixes to the driver are needed.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> ---
> drivers/media/i2c/dw9768.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/media/i2c/dw9768.c b/drivers/media/i2c/dw9768.c
> index 65c6acf3ced9a..c086580efac78 100644
> --- a/drivers/media/i2c/dw9768.c
> +++ b/drivers/media/i2c/dw9768.c
> @@ -469,11 +469,6 @@ static int dw9768_probe(struct i2c_client *client)
>
> dw9768->sd.entity.function = MEDIA_ENT_F_LENS;
>
> - /*
> - * Device is already turned on by i2c-core with ACPI domain PM.
> - * Attempt to turn off the device to satisfy the privacy LED concerns.
> - */
> - pm_runtime_set_active(dev);
> pm_runtime_enable(dev);
> if (!pm_runtime_enabled(dev)) {
> ret = dw9768_runtime_resume(dev);
> @@ -488,7 +483,6 @@ static int dw9768_probe(struct i2c_client *client)
> dev_err(dev, "failed to register V4L2 subdev: %d", ret);
> goto err_power_off;
> }
> - pm_runtime_idle(dev);
>
> return 0;
>
> --
> 2.30.2
>
Thanks for a quick response!
Reviewed-by: Tomasz Figa <tfiga@xxxxxxxxxxxx>
Best regards,
Tomasz
