Re: [RESEND PATCH 1/2] media: dt-bindings: imx412: Add regulator descriptions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/04/2022 18:35, Bryan O'Donoghue wrote:
> The imx412 like many I2C camera sensors has three voltage rails which
> depending on platform may be necessary to switch power onto directly.
> 
> Add in as optional rails so as not to break anything for existing users.

Thank you for your patch. There is something to discuss/improve.

> 
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/media/i2c/sony,imx412.yaml   | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
> index afcf70947f7e..16869a91ec9a 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
> @@ -32,6 +32,18 @@ properties:
>      description: Clock frequency 6MHz, 12MHz, 18MHz, 24MHz or 27MHz
>      maxItems: 1
>  
> +  dovdd-supply:
> +    description:
> +      Definition of the regulator used as interface power supply.
>

You could shorten this to "interface power supply", because other parts
of the sentence do not describe the hardware more detailed. Similarly in
other properties. An any case, looks good:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux