Quoting Laurent Pinchart (2022-03-21 14:51:34) > From: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > Matching on device fwnode handles is deprecated in favour of endpoint > fwnode handles. Switch the __v4l2_async_nf_add_fwnode_remote() function > to use the latter. The match code handles backward compatibility by > falling by to the device fwnode handle, so this shouldn't introduce any s/by/back/ ? It sounds like this helps move other devices towards endpoint matching more generically too, but I expect there will still be more specifics to handle in receiver drivers? And indeed the whole point of the fallback case was to make them compatible... so: Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> But I suspect this needs some testing on platforms that haven't yet moved to endpoint matching.. ? > regression. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > --- > drivers/media/v4l2-core/v4l2-async.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c > index 0404267f1ae4..67d7f445d429 100644 > --- a/drivers/media/v4l2-core/v4l2-async.c > +++ b/drivers/media/v4l2-core/v4l2-async.c > @@ -662,7 +662,7 @@ __v4l2_async_nf_add_fwnode_remote(struct v4l2_async_notifier *notif, > struct v4l2_async_subdev *asd; > struct fwnode_handle *remote; > > - remote = fwnode_graph_get_remote_port_parent(endpoint); > + remote = fwnode_graph_get_remote_endpoint(endpoint); > if (!remote) > return ERR_PTR(-ENOTCONN); > > -- > Regards, > > Laurent Pinchart >
