On Tue, Mar 08, 2022 at 06:10:05PM +0100, Alain Volmat wrote: > Hi Andy, > > sorry for the delay. > > Reviewed-by: Alain Volmat <alain.volmat@xxxxxxxxxxx> Thanks! Can it be applied now? > On Tue, Mar 08, 2022 at 12:25:42PM +0200, Andy Shevchenko wrote: > > On Wed, Mar 02, 2022 at 05:51:42PM +0200, Andy Shevchenko wrote: > > > On Wed, Feb 09, 2022 at 08:25:21PM +0200, Andy Shevchenko wrote: > > > > There are a few cases where code is harder than needed to read. > > > > Improve those by: > > > > - dropping unnecessary castings (see note below) > > > > - use PTR_ALING() to be more explicit on what's going on there > > > > - use proper definitions instead of hard coded values > > > > > > > > Note, dropping castings will allow to perform an additional check > > > > that type is not changed from void * to something else, e.g. u64, > > > > which may very well break the bitmap APIs. > > > > > > Any comments on it? -- With Best Regards, Andy Shevchenko
