Hey Laurent,
Many thanks for the fix.
On Mon, Mar 21, 2022 at 05:30:20PM +0200, Laurent Pinchart wrote:
> Commit 52f69bc5f8c0 ("media: imx: csis: Store pads format separately")
> broke initialization of the active format on the source pad, as it
> forgot to update the .init_cfg() handler. Fix it.
>
> Fixes: 52f69bc5f8c0 ("media: imx: csis: Store pads format separately")
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
LGTM.
Acked-by: Rui Miguel Silva <rmfrfs@xxxxxxxxx>
Cheers,
Rui
> ---
> drivers/media/platform/imx/imx-mipi-csis.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/media/platform/imx/imx-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c
> index 6d03d89fb5d8..9da105d37987 100644
> --- a/drivers/media/platform/imx/imx-mipi-csis.c
> +++ b/drivers/media/platform/imx/imx-mipi-csis.c
> @@ -1014,14 +1014,6 @@ static int mipi_csis_init_cfg(struct v4l2_subdev *sd,
> V4L2_MAP_QUANTIZATION_DEFAULT(false, fmt_sink->colorspace,
> fmt_sink->ycbcr_enc);
>
> - /*
> - * When called from mipi_csis_subdev_init() to initialize the active
> - * configuration, cfg is NULL, which indicates there's no source pad
> - * configuration to set.
> - */
> - if (!sd_state)
> - return 0;
> -
> fmt_source = mipi_csis_get_format(csis, sd_state, which,
> CSIS_PAD_SOURCE);
> *fmt_source = *fmt_sink;
> --
> Regards,
>
> Laurent Pinchart
>
