Re: [PATCH 1/2] dt-bindings: Convert Dongwoon dw9807-vcm bindings to json-schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18/03/2022 17:51, Sakari Ailus wrote:
> Convert the old text based dw9807-vcm chip DT bindings to json-schema.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> ---
>  .../media/i2c/dongwoon,dw9807-vcm.txt         |  9 ----
>  .../media/i2c/dongwoon,dw9807-vcm.yaml        | 43 +++++++++++++++++++
>  2 files changed, 43 insertions(+), 9 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.txt
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.txt b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.txt
> deleted file mode 100644
> index c4701f1eaaf63..0000000000000
> --- a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.txt
> +++ /dev/null
> @@ -1,9 +0,0 @@
> -Dongwoon Anatech DW9807 voice coil lens driver
> -
> -DW9807 is a 10-bit DAC with current sink capability. It is intended for
> -controlling voice coil lenses.
> -
> -Mandatory properties:
> -
> -- compatible: "dongwoon,dw9807-vcm"
> -- reg: I2C slave address
> diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.yaml b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.yaml
> new file mode 100644
> index 0000000000000..0cf153ed547fe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2018, 2021 Intel Corporation
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/dongwoon,dw9807-vcm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Dongwoon Anatech DW9807 voice coil lens driver
> +
> +maintainers:
> +  - Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> +
> +description: |
> +  DW9807 is a 10-bit DAC with current sink capability. It is intended for
> +  controlling voice coil lenses.
> +
> +properties:
> +

No blank line.

> +  compatible:
> +    const: "dongwoon,dw9807-vcm"

No quotes.

> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +

No blank line.


With the changes above:

Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Best regards,
Krzysztof



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux