Re: [PATCH] media: platform: renesas-ceu: Fix unused variable warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 18, 2022 at 10:04:33AM +0000, Kieran Bingham wrote:
> Quoting Laurent Pinchart (2022-03-17 20:49:03)
> > The ceu_data_rz variable is unused when CONFIG_OF isn't set. This
> > generates a compiler warning. Fix it.
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx> ?

Good point, I forgot that. Thanks.

> but either way: 
> 
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
> 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > ---
> >  drivers/media/platform/renesas/renesas-ceu.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/media/platform/renesas/renesas-ceu.c b/drivers/media/platform/renesas/renesas-ceu.c
> > index 2e8dbacc414e..f70f91b006b7 100644
> > --- a/drivers/media/platform/renesas/renesas-ceu.c
> > +++ b/drivers/media/platform/renesas/renesas-ceu.c
> > @@ -1606,15 +1606,15 @@ struct ceu_data {
> >         u32 irq_mask;
> >  };
> >  
> > -static const struct ceu_data ceu_data_rz = {
> > -       .irq_mask = CEU_CETCR_ALL_IRQS_RZ,
> > -};
> > -
> >  static const struct ceu_data ceu_data_sh4 = {
> >         .irq_mask = CEU_CETCR_ALL_IRQS_SH4,
> >  };
> >  
> >  #if IS_ENABLED(CONFIG_OF)
> > +static const struct ceu_data ceu_data_rz = {
> > +       .irq_mask = CEU_CETCR_ALL_IRQS_RZ,
> > +};
> > +
> >  static const struct of_device_id ceu_of_match[] = {
> >         { .compatible = "renesas,r7s72100-ceu", .data = &ceu_data_rz },
> >         { .compatible = "renesas,r8a7740-ceu", .data = &ceu_data_rz },
> > 
> > base-commit: 10ed1ec9c9cab63310038579c2e1303324bfa44a

-- 
Regards,

Laurent Pinchart



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux