Hi Moudy, >> > } >> > } >> > >> > + if (of_address_to_resource(dev->of_node, 0, &addr) < 0) >> > + mtx->addr = 0L; >> >> addr is phys_addr_t, which means that it holds a physical address. >> 0 may be a valid address in some platforms, so I think >> we should not set mtx->addr = 0L when of_address_to_resource fails. >> Maybe probe fail by returning dev_err_probe()? >> >> Thanks, >> Miles > >Hi Miles, > >This does lead to the situation you mentioned, and sorry for the >deficient dts parsing flow. Maybe we should follow "gce-client" usage >and add a check condition when needed to avoid compatibility issues? > >Thanks, >Moudy According to Documentation/devicetree/bindings/display/mediatek/mediatek,mutex.yaml, it is required to have a reg field in the mutex node. So I think we can fail in this case. Thanks, Miles
