[PATCHv3 0/7] cec: various fixes and enhancements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The first two patches fix issues relating to a CEC adapter
being disabled while a transmit is still in progress at the
hardware level. Unless the hardware is really disabled (i.e.
loses power) the transmit should just continue in order to
keep the hardware and framework state in sync, and to avoid
half-written messages on the bus.

The third patch fixes a mismatch between the API documentation
and the actual code w.r.t. reporting the results of a non-blocking
transmit.

The fourth patch adds helpers to make it easier for both drivers
and userspace to detect if the received message contains the
result of a non-blocking transmit.

The fifth patch makes the framework more robust, preventing ops
from being called when the device is already unregistered.

The last two patches add new features that are needed for an
out-of-tree CEC driver:

https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=extron

This is still work in progress, so these patches will probably
be included in the submission of that driver.

Regards,

	Hans

Changes since v2:

- added "cec: use call_op and check for !unregistered"

Changes since v1:

- replace bool by int in the public cec.h header for the new
  helper functions
- rework "cec: call enable_adap on s_log_addrs": it did not take
  monitoring into account (while monitoring the CEC adapter has
  to be enabled, even when unconfigured) and the needs_hpd case
  wasn't handled quite right either.

Hans Verkuil (7):
  cec: call enable_adap on s_log_addrs
  cec: abort if the current transmit was canceled
  cec: correctly pass on reply results
  cec.h: add cec_msg_recv_is_rx/tx_result helpers
  cec: use call_op and check for !unregistered
  cec: add xfer_timeout_ms field
  cec: add optional adap_configured callback

 Documentation/driver-api/media/cec-core.rst |  13 +-
 drivers/media/cec/core/cec-adap.c           | 279 +++++++++++++-------
 drivers/media/cec/core/cec-api.c            |  24 +-
 drivers/media/cec/core/cec-core.c           |  18 +-
 drivers/media/cec/core/cec-pin-priv.h       |  11 +
 drivers/media/cec/core/cec-pin.c            |  23 +-
 drivers/media/cec/core/cec-priv.h           |  10 +
 include/media/cec.h                         |  12 +
 include/uapi/linux/cec.h                    |  20 ++
 9 files changed, 275 insertions(+), 135 deletions(-)

-- 
2.34.1




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux