The "bdisp->clock" variable cannot be an error pointer here. No need to check. Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> --- drivers/media/platform/stm/sti/bdisp/bdisp-v4l2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/platform/stm/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/stm/sti/bdisp/bdisp-v4l2.c index 5aa79d9277c8..dd74cc43920d 100644 --- a/drivers/media/platform/stm/sti/bdisp/bdisp-v4l2.c +++ b/drivers/media/platform/stm/sti/bdisp/bdisp-v4l2.c @@ -1394,8 +1394,7 @@ static int bdisp_probe(struct platform_device *pdev) bdisp_debugfs_remove(bdisp); v4l2_device_unregister(&bdisp->v4l2_dev); err_clk: - if (!IS_ERR(bdisp->clock)) - clk_unprepare(bdisp->clock); + clk_unprepare(bdisp->clock); err_wq: destroy_workqueue(bdisp->work_queue); return ret; -- 2.20.1