Hi Jacopo,
Thank you for the patch.
On Mon, Mar 14, 2022 at 11:39:40AM +0100, Jacopo Mondi wrote:
> The mipi_csis_log_counters() function already checks for
> csis->debug.enable, it is not necessary to do the same in the caller.
Does it ? It does only to decide whether or not to print counters that
have a zero value.
> Compatc the code in the caller as well by removing an empty line.
>
> Signed-off-by: Jacopo Mondi <jacopo@xxxxxxxxxx>
> ---
> drivers/media/platform/imx/imx-mipi-csis.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/imx/imx-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c
> index 4a6152c13d52..4bb469fcb6b3 100644
> --- a/drivers/media/platform/imx/imx-mipi-csis.c
> +++ b/drivers/media/platform/imx/imx-mipi-csis.c
> @@ -913,11 +913,8 @@ static int mipi_csis_s_stream(struct v4l2_subdev *sd, int enable)
>
> if (!enable) {
> v4l2_subdev_call(csis->src_sd, video, s_stream, 0);
> -
> mipi_csis_stop_stream(csis);
> - if (csis->debug.enable)
> - mipi_csis_log_counters(csis, true);
> -
> + mipi_csis_log_counters(csis, true);
> pm_runtime_put(csis->dev);
>
> return 0;
--
Regards,
Laurent Pinchart
