Hi Jacopo, I love your patch! Yet something to improve: [auto build test ERROR on media-tree/master] [also build test ERROR on v5.17-rc7 next-20220310] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jacopo-Mondi/media-i2c-ov5670-OF-support-runtime_pm-regulators/20220310-211143 base: git://linuxtv.org/media_tree.git master config: x86_64-randconfig-a016 (https://download.01.org/0day-ci/archive/20220311/202203110433.anTyFE5N-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 276ca87382b8f16a65bddac700202924228982f6) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/f5425877ffa93005c9f71ce9ce4185a787db66eb git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jacopo-Mondi/media-i2c-ov5670-OF-support-runtime_pm-regulators/20220310-211143 git checkout f5425877ffa93005c9f71ce9ce4185a787db66eb # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/media/i2c/ov5670.c:2601:34: error: use of undeclared identifier 'ov5670_of_ids' .of_match_table = of_match_ptr(ov5670_of_ids), ^ 1 error generated. vim +/ov5670_of_ids +2601 drivers/media/i2c/ov5670.c 2595 2596 static struct i2c_driver ov5670_i2c_driver = { 2597 .driver = { 2598 .name = "ov5670", 2599 .pm = &ov5670_pm_ops, 2600 .acpi_match_table = ACPI_PTR(ov5670_acpi_ids), > 2601 .of_match_table = of_match_ptr(ov5670_of_ids), 2602 }, 2603 .probe_new = ov5670_probe, 2604 .remove = ov5670_remove, 2605 .flags = I2C_DRV_ACPI_WAIVE_D0_PROBE, 2606 }; 2607 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx