Hi Fabio, Nicolas,
On Mi, 2022-03-09 at 17:20 +0100, Philipp Zabel wrote:
[...]
> I still think this is wrong [1], the vendor only advertises support
> for level 4.0. At least level 5.0 must be dropped, as we don't
> support the frame size requirement.
Looking at my notes, I've never seen the encoder produce streams with
levels 1.1, 1.2, 1.3, 2.1, 2.2, or 4.1. Has anybody else?
Level 4.2 streams can be produced though, just not at realtime speeds.
Also, this encoder control change has no effect unless max is changed
as well. I think it should look as follows:
if (ctx->dev->devtype->product == CODA_960) {
v4l2_ctrl_new_std_menu(&ctx->ctrls, &coda_ctrl_ops,
V4L2_CID_MPEG_VIDEO_H264_LEVEL,
- V4L2_MPEG_VIDEO_H264_LEVEL_4_0,
- ~((1 << V4L2_MPEG_VIDEO_H264_LEVEL_2_0) |
+ V4L2_MPEG_VIDEO_H264_LEVEL_4_2,
+ ~((1 << V4L2_MPEG_VIDEO_H264_LEVEL_1_0) |
+ (1 << V4L2_MPEG_VIDEO_H264_LEVEL_2_0) |
(1 << V4L2_MPEG_VIDEO_H264_LEVEL_3_0) |
(1 << V4L2_MPEG_VIDEO_H264_LEVEL_3_1) |
(1 << V4L2_MPEG_VIDEO_H264_LEVEL_3_2) |
- (1 << V4L2_MPEG_VIDEO_H264_LEVEL_4_0)),
+ (1 << V4L2_MPEG_VIDEO_H264_LEVEL_4_0) |
+ (1 << V4L2_MPEG_VIDEO_H264_LEVEL_4_2)),
V4L2_MPEG_VIDEO_H264_LEVEL_4_0);
}
v4l2_ctrl_new_std(&ctx->ctrls, &coda_ctrl_ops,
regards
Philipp
