I'll send a v2 shortly.
Thanks,
Laurentiu
>
> > > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@xxxxxxxxxxx>
> > > ---
> > > drivers/media/i2c/max9286.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> > > index d2a4915ed9f7..04f5b7e3a9e5 100644
> > > --- a/drivers/media/i2c/max9286.c
> > > +++ b/drivers/media/i2c/max9286.c
> > > @@ -1385,7 +1385,7 @@ static int max9286_probe(struct i2c_client *client)
> > >
> > > static int max9286_remove(struct i2c_client *client)
> > > {
> > > - struct max9286_priv *priv = i2c_get_clientdata(client);
> > > + struct max9286_priv *priv = sd_to_max9286(i2c_get_clientdata(client));
> >
> > What happens if the module load failed before calling max9286_init(), in
> > that case, would the i2c_get_clientdata() return NULL?
> >
> > If so, should this be checked?
>
> .remove() isn't called if .probe() fails, so it should be fine
>
> > >
> > > i2c_mux_del_adapters(priv->mux);
> > >
>
> --
> Regards,
>
> Laurent Pinchart
