On 3/2/22 7:44 AM, Miaoqian Lin wrote: > On Tue, Mar 01, 2022 at 01:51:02PM +0000, Eugen.Hristev@xxxxxxxxxxxxx wrote: >>> --- >>> changes in v2: >>> - remove unused label. >>> --- >>> drivers/media/platform/atmel/atmel-sama5d2-isc.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c >>> index 1b2063cce0f7..7f1ebbb25437 100644 >>> --- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c >>> +++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c >>> @@ -559,6 +559,8 @@ static int atmel_isc_probe(struct platform_device *pdev) >>> cleanup_subdev: >>> isc_subdev_cleanup(isc); >>> >>> + pm_runtime_disable(dev); >>> + >> >> Hello Miaoqian Lin , >> >> Could you please perform the same change (or similar) in >> atmel-sama7g5-isc , as the sama7g5 ISC will perform the same and has the >> same bug. >> > Hi, Eugen Hristev: > > I think you are referring to microchip_xisc_probe() function in > atmel-sama7g5-isc, and I have look into it. After it calls > pm_runtime_enable(), it only have a regular path whichs return 0 and > indicates > the probe is successful. It doesn't have error handling path. Hi, You are right. It will always have a success path. Your patch is fine for me : Reviewed-by: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx> Thanks ! > > regmap_read() function returns a negative errno in error cases, but it > is used to get Microchip XISC version. I am not sure if failure means > the probe fails. >>> unregister_v4l2_device: >>> v4l2_device_unregister(&isc->v4l2_dev); >>> >>> -- >>> 2.17.1 >>> >>
