On Sat, Feb 26, 2022 at 4:06 AM Daniel Scally <djrscally@xxxxxxxxx> wrote: > > Hi Andy > > On 25/02/2022 16:57, Andy Shevchenko wrote: > > On Fri, Feb 25, 2022 at 12:07:44AM +0000, Daniel Scally wrote: > >> We have platforms where a camera sensor transmits Y10 data to > >> the CIO2 device - add support for that (packed) format to the > >> ipu3-cio2 driver. > > ... > > > >> - }, > > Why? > > > Why have the open and close brace on the same line you mean? Its just > the format that the other entries use, so I copied it. I meant why you touched that line and as a consequence removed the comma. > >> + }, { > >> + .mbus_code = MEDIA_BUS_FMT_Y10_1X10, > >> + .fourcc = V4L2_PIX_FMT_IPU3_Y10, > >> + .mipicode = 0x2b, > >> + .bpp = 10, > >> + } -- With Best Regards, Andy Shevchenko