Re: [PATCH v10 2/2] media: i2c: isl7998x: Add driver for Intersil ISL7998x

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michael,

On Thu, Feb 17, 2022 at 04:44:07PM +0100, Michael Tretter wrote:
> From: Marek Vasut <marex@xxxxxxx>
> 
> Add driver for the Intersil ISL7998x Analog to MIPI CSI-2/BT656 decoder.
> This chip supports 1/2/4 analog video inputs and converts them into
> 1/2/4 VCs in MIPI CSI2 stream.
> 
> This driver currently supports ISL79987 and both 720x480 and 720x576
> resolutions, however as per specification, all inputs must use the
> same resolution and standard. The only supported pixel format is now
> YUYV/YUV422. The chip should support RGB565 on the CSI2 as well, but
> this is currently unsupported.
> 
> Signed-off-by: Marek Vasut <marex@xxxxxxx>
> Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> Cc: Mauro Carvalho Chehab <mchehab+samsung@xxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> To: linux-media@xxxxxxxxxxxxxxx
> Signed-off-by: Michael Tretter <m.tretter@xxxxxxxxxxxxxx>

This gives (sparse or smatch presumably?):

        ../drivers/media/i2c/isl7998x.c: ../drivers/media/i2c/isl7998x.c:561    
isl7998x_norm_to_val() error: buffer overflow 'isl7998x_std_res' 9 <= 9         
(assuming for loop doesn't break)                                               
        ../drivers/media/i2c/isl7998x.c: ../drivers/media/i2c/isl7998x.c:576    
isl7998x_norm_to_mode() error: buffer overflow 'isl7998x_std_res' 9 <= 9        
(assuming for loop doesn't break)                                               

Could you address that? I'll squash that to this patch.

-- 
Sakari Ailus



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux