Laurent, This is a good fix. For example, soc based sub devices may not have core ops implemented. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 email: m-karicheri2@xxxxxx >-----Original Message----- >From: linux-media-owner@xxxxxxxxxxxxxxx [mailto:linux-media- >owner@xxxxxxxxxxxxxxx] On Behalf Of Laurent Pinchart >Sent: Wednesday, July 07, 2010 7:53 AM >To: linux-media@xxxxxxxxxxxxxxx >Cc: sakari.ailus@xxxxxxxxxxxxxxxxxxxxxxxxxx >Subject: [RFC/PATCH 1/6] v4l: subdev: Don't require core operations > >There's no reason to require subdevices to implement the core >operations. Remove the check for non-NULL core operations when >initializing the subdev. > >Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> >--- > include/media/v4l2-subdev.h | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > >diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h >index 02c6f4d..6088316 100644 >--- a/include/media/v4l2-subdev.h >+++ b/include/media/v4l2-subdev.h >@@ -437,8 +437,7 @@ static inline void v4l2_subdev_init(struct v4l2_subdev >*sd, > const struct v4l2_subdev_ops *ops) > { > INIT_LIST_HEAD(&sd->list); >- /* ops->core MUST be set */ >- BUG_ON(!ops || !ops->core); >+ BUG_ON(!ops); > sd->ops = ops; > sd->v4l2_dev = NULL; > sd->flags = 0; >-- >1.7.1 > >-- >To unsubscribe from this list: send the line "unsubscribe linux-media" in >the body of a message to majordomo@xxxxxxxxxxxxxxx >More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
