Re: [PATCH 2/2] v4l: fwnode: Remove now-redundant loop from v4l2_fwnode_parse_reference()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 23, 2022 at 02:22:25PM +0200, Laurent Pinchart wrote:
> Hi Sakari,
> 
> Thank you for the patch.
> 
> On Wed, Feb 23, 2022 at 01:54:34PM +0200, Sakari Ailus wrote:
> > v4l2_fwnode_parse_reference() relied on counting the number of references
> > for async array memory allocation. The array is long gone so remove
> > counting the references now.
> > 
> > This also changes how the function arrives in different unsuccessful
> > return values but the functionality remains unchanged.
> > 
> > Also the check for -ENODATA is removed, it was made redundant by commit
> > c343bc2ce2c6 ("ACPI: properties: Align return codes of
> > __acpi_node_get_property_reference()").
> 
> This paragraph should be dropped.
> 
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

Thanks for the review.

I'll drop it when applying.

-- 
Sakari Ailus



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux