Hi Sakari,
Thank you for the patch.
On Wed, Feb 23, 2022 at 01:54:33PM +0200, Sakari Ailus wrote:
> The check of -ENODATA return value from
> fwnode_property_get_reference_args() was made redundant by commit
> c343bc2ce2c6 ("ACPI: properties: Align return codes of
> __acpi_node_get_property_reference()"). -ENOENT remains to be used to
> signal there are no further entries.
>
> Remove the check for -ENODATA.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/v4l2-core/v4l2-fwnode.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c
> index 71dcc9a96535..ae140443847b 100644
> --- a/drivers/media/v4l2-core/v4l2-fwnode.c
> +++ b/drivers/media/v4l2-core/v4l2-fwnode.c
> @@ -903,11 +903,7 @@ static int v4l2_fwnode_reference_parse(struct device *dev,
> if (!index)
> return -ENOENT;
>
> - /*
> - * Note that right now both -ENODATA and -ENOENT may signal
> - * out-of-bounds access. Return the error in cases other than that.
> - */
> - if (ret != -ENOENT && ret != -ENODATA)
> + if (ret != -ENOENT)
> return ret;
>
> for (index = 0;
--
Regards,
Laurent Pinchart
