Hi Linus, I love your patch! Yet something to improve: [auto build test ERROR on media-tree/master] [also build test ERROR on v5.17-rc5 next-20220217] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Linus-Walleij/media-cec-seco-Drop-pointless-include/20220223-000503 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-a014-20220221 (https://download.01.org/0day-ci/archive/20220223/202202230527.2mRa4oUA-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/3b2630b860ba004410fd27ad657355bcc0b9bd72 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Linus-Walleij/media-cec-seco-Drop-pointless-include/20220223-000503 git checkout 3b2630b860ba004410fd27ad657355bcc0b9bd72 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/media/cec/platform/seco/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/media/cec/platform/seco/seco-cec.c:553:35: error: use of undeclared identifier 'GPIOF_IN'; did you mean 'GPIOD_IN'? gpio = devm_gpiod_get(dev, NULL, GPIOF_IN); ^~~~~~~~ GPIOD_IN include/linux/gpio/consumer.h:51:2: note: 'GPIOD_IN' declared here GPIOD_IN = GPIOD_FLAGS_BIT_DIR_SET, ^ 1 error generated. vim +553 drivers/media/cec/platform/seco/seco-cec.c b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 546 b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 547 static int secocec_acpi_probe(struct secocec_data *sdev) b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 548 { b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 549 struct device *dev = sdev->dev; b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 550 struct gpio_desc *gpio; b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 551 int irq = 0; b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 552 b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 @553 gpio = devm_gpiod_get(dev, NULL, GPIOF_IN); b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 554 if (IS_ERR(gpio)) { b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 555 dev_err(dev, "Cannot request interrupt gpio"); b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 556 return PTR_ERR(gpio); b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 557 } b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 558 b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 559 irq = gpiod_to_irq(gpio); b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 560 if (irq < 0) { b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 561 dev_err(dev, "Cannot find valid irq"); b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 562 return -ENODEV; b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 563 } b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 564 dev_dbg(dev, "irq-gpio is bound to IRQ %d", irq); b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 565 b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 566 sdev->irq = irq; b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 567 b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 568 return 0; b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 569 } b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 570 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
