Hi Jacopo,
Thank you for the patch.
On Thu, Feb 10, 2022 at 12:10:00PM +0100, Jacopo Mondi wrote:
> Now that the frame duration can be controlled by tuning the VBLANK
> duration, fix all modes to comply with the reported FPS.
>
> All modes run at 30 FPS except for full-resolution mode 2592x1944
> which runs at 15FPS.
>
> Tested on a 2 data lanes setup in UYVY and RGB565 modes.
>
> Signed-off-by: Jacopo Mondi <jacopo@xxxxxxxxxx>
I'll trust your calculations.
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/i2c/ov5640.c | 30 +++++++++++++++---------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> index 30b706a98eb9..dd7ff1bb580f 100644
> --- a/drivers/media/i2c/ov5640.c
> +++ b/drivers/media/i2c/ov5640.c
> @@ -648,8 +648,8 @@ static const struct ov5640_mode_info ov5640_mode_data[OV5640_NUM_MODES] = {
> .width = 160,
> .height = 120,
> },
> - .htot = 1896,
> - .vblank_def = 864,
> + .htot = 1600,
> + .vblank_def = 878,
> .reg_data = ov5640_setting_QQVGA_160_120,
> .reg_data_size = ARRAY_SIZE(ov5640_setting_QQVGA_160_120),
> .max_fps = OV5640_30_FPS
> @@ -672,8 +672,8 @@ static const struct ov5640_mode_info ov5640_mode_data[OV5640_NUM_MODES] = {
> .width = 176,
> .height = 144,
> },
> - .htot = 1896,
> - .vblank_def = 840,
> + .htot = 1600,
> + .vblank_def = 854,
> .reg_data = ov5640_setting_QCIF_176_144,
> .reg_data_size = ARRAY_SIZE(ov5640_setting_QCIF_176_144),
> .max_fps = OV5640_30_FPS
> @@ -696,8 +696,8 @@ static const struct ov5640_mode_info ov5640_mode_data[OV5640_NUM_MODES] = {
> .width = 320,
> .height = 240,
> },
> - .htot = 1896,
> - .vblank_def = 744,
> + .htot = 1600,
> + .vblank_def = 760,
> .reg_data = ov5640_setting_QVGA_320_240,
> .reg_data_size = ARRAY_SIZE(ov5640_setting_QVGA_320_240),
> .max_fps = OV5640_30_FPS
> @@ -720,8 +720,8 @@ static const struct ov5640_mode_info ov5640_mode_data[OV5640_NUM_MODES] = {
> .width = 640,
> .height = 480,
> },
> - .htot = 1896,
> - .vblank_def = 600,
> + .htot = 1600,
> + .vblank_def = 520,
> .reg_data = ov5640_setting_VGA_640_480,
> .reg_data_size = ARRAY_SIZE(ov5640_setting_VGA_640_480),
> .max_fps = OV5640_60_FPS
> @@ -745,7 +745,7 @@ static const struct ov5640_mode_info ov5640_mode_data[OV5640_NUM_MODES] = {
> .height = 480,
> },
> .htot = 1896,
> - .vblank_def = 504,
> + .vblank_def = 1206,
> .reg_data = ov5640_setting_NTSC_720_480,
> .reg_data_size = ARRAY_SIZE(ov5640_setting_NTSC_720_480),
> .max_fps = OV5640_30_FPS
> @@ -769,7 +769,7 @@ static const struct ov5640_mode_info ov5640_mode_data[OV5640_NUM_MODES] = {
> .height = 576,
> },
> .htot = 1896,
> - .vblank_def = 408,
> + .vblank_def = 1110,
> .reg_data = ov5640_setting_PAL_720_576,
> .reg_data_size = ARRAY_SIZE(ov5640_setting_PAL_720_576),
> .max_fps = OV5640_30_FPS
> @@ -793,7 +793,7 @@ static const struct ov5640_mode_info ov5640_mode_data[OV5640_NUM_MODES] = {
> .height = 768,
> },
> .htot = 1896,
> - .vblank_def = 312,
> + .vblank_def = 918,
> .reg_data = ov5640_setting_XGA_1024_768,
> .reg_data_size = ARRAY_SIZE(ov5640_setting_XGA_1024_768),
> .max_fps = OV5640_30_FPS
> @@ -816,8 +816,8 @@ static const struct ov5640_mode_info ov5640_mode_data[OV5640_NUM_MODES] = {
> .width = 1280,
> .height = 720,
> },
> - .htot = 1892,
> - .vblank_def = 20,
> + .htot = 1600,
> + .vblank_def = 560,
> .reg_data = ov5640_setting_720P_1280_720,
> .reg_data_size = ARRAY_SIZE(ov5640_setting_720P_1280_720),
> .max_fps = OV5640_30_FPS
> @@ -840,8 +840,8 @@ static const struct ov5640_mode_info ov5640_mode_data[OV5640_NUM_MODES] = {
> .width = 1920,
> .height = 1080,
> },
> - .htot = 2500,
> - .vblank_def = 40,
> + .htot = 2234,
> + .vblank_def = 24,
> .reg_data = ov5640_setting_1080P_1920_1080,
> .reg_data_size = ARRAY_SIZE(ov5640_setting_1080P_1920_1080),
> .max_fps = OV5640_30_FPS
--
Regards,
Laurent Pinchart
