Hi Daniel, I love your patch! Perhaps something to improve: [auto build test WARNING on media-tree/master] [also build test WARNING on v5.17-rc4 next-20220215] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Scally/Support-OVTI7251-on-Microsoft-Surface-line/20220216-071110 base: git://linuxtv.org/media_tree.git master config: riscv-randconfig-r003-20220216 (https://download.01.org/0day-ci/archive/20220216/202202161122.Qh05mcn0-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0e628a783b935c70c80815db6c061ec84f884af5) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/0day-ci/linux/commit/5c7425707438fee74daeb7faf41774d88a04b561 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Daniel-Scally/Support-OVTI7251-on-Microsoft-Surface-line/20220216-071110 git checkout 5c7425707438fee74daeb7faf41774d88a04b561 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/media/i2c/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/media/i2c/ov7251.c:190:31: warning: unused variable 'ov7251_global_init_setting' [-Wunused-const-variable] static const struct reg_value ov7251_global_init_setting[] = { ^ 1 warning generated. vim +/ov7251_global_init_setting +190 drivers/media/i2c/ov7251.c 9276bc868a46fc Daniel Scally 2022-02-15 189 d30bb512da3d8e Todor Tomov 2018-04-25 @190 static const struct reg_value ov7251_global_init_setting[] = { d30bb512da3d8e Todor Tomov 2018-04-25 191 { 0x0103, 0x01 }, d30bb512da3d8e Todor Tomov 2018-04-25 192 { 0x303b, 0x02 }, d30bb512da3d8e Todor Tomov 2018-04-25 193 }; d30bb512da3d8e Todor Tomov 2018-04-25 194 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx