Hi Eugen, On Tue, Feb 08, 2022 at 11:36:16AM +0000, Eugen.Hristev@xxxxxxxxxxxxx wrote: > I am sorry, I was referring to the get_mbus_config which was recently > added, which in my case uses V4L2_MBUS_CSI2_CHANNEL_* . > Without the get_mbus_config, I wasn't supposed to use the > V4L2_MBUS_CSI2_CHANNEL_* at all . > Hence my confusion in adding them into the same bucket. > > My driver uses these flags because my initial implementation to get the > VC from the devicetree was rejected and this was suggested instead. As noted by Laurent, this feature is not supported in mainline currently. Beyond that, no transmitter driver uses virtual channel different from zero, so the case for setting non-zero virtual channel in absence of multiple streams does not exist. Also the interfaces required to make use of multiple streams do not exist in mainline at the moment. They will be added by the streams patchset eventually, and adding support for them requires extra driver work. Thus, we're not losing any functionality by dropping the defines and potentially associated driver code. Therefore I see no reason to postpone these patches. -- Kind regards, Sakari Ailus
