Thanks Mauro. I'll discuss with the team and come up with a solution for this. BTW, any update on the Polaris patches? I had resent the 1/2 an 2/2 patches. Thanks, Palash ________________________________________ From: Mauro Carvalho Chehab [mchehab@xxxxxxxxxx] Sent: Sunday, July 04, 2010 10:26 PM To: Palash Bandyopadhyay Cc: linux-media@xxxxxxxxxxxxxxx; Jay Guillory Subject: Re: [cx25821] Removed duplicate code and cleaned up Em 10-06-2010 01:27, Palash Bandyopadhyay escreveu: > From 58fd4cad5f6acbe16bff86b8e878d2352cc73637 Mon Sep 17 00:00:00 2001 > Message-Id: <58fd4cad5f6acbe16bff86b8e878d2352cc73637.1276143362.git.palash.bandyopadhyay@xxxxxxxxxxxx> > From: palash <palash.bandyopadhyay@xxxxxxxxxxxx> > Date: Wed, 9 Jun 2010 21:11:20 -0700 > Subject: [cx25821] Removed duplicate code and cleaned up > To: linux-media@xxxxxxxxxxxxxxx > > Signed-off-by: palash <palash.bandyopadhyay@xxxxxxxxxxxx> > > delete mode 100644 drivers/staging/cx25821/cx25821-audups11.c > delete mode 100644 drivers/staging/cx25821/cx25821-video0.c > delete mode 100644 drivers/staging/cx25821/cx25821-video1.c > delete mode 100644 drivers/staging/cx25821/cx25821-video2.c > delete mode 100644 drivers/staging/cx25821/cx25821-video3.c > delete mode 100644 drivers/staging/cx25821/cx25821-video4.c > delete mode 100644 drivers/staging/cx25821/cx25821-video5.c > delete mode 100644 drivers/staging/cx25821/cx25821-video6.c > delete mode 100644 drivers/staging/cx25821/cx25821-video7.c > delete mode 100644 drivers/staging/cx25821/cx25821-videoioctl.c > delete mode 100644 drivers/staging/cx25821/cx25821-vidups10.c > delete mode 100644 drivers/staging/cx25821/cx25821-vidups9.c Hi Palash, I've applied your patch at "staging/other" branch, and added there a few patches to cleanup some troubles I saw on the driver. I was wanting to move it out of staging, but, unfortunately, the driver is not ready yet. One of the bad things I saw on the driver is this part: $ grep /root/ drivers/staging/cx25821/* drivers/staging/cx25821/cx25821-audio-upstream.c: dev->_audiofilename = "/root/audioGOOD.wav"; drivers/staging/cx25821/cx25821-audio-upstream.h:char *_defaultAudioName = "/root/audioGOOD.wav"; drivers/staging/cx25821/cx25821-video-upstream.c: PIXEL_FRMT_411) ? "/root/vid411.yuv" : drivers/staging/cx25821/cx25821-video-upstream.c: "/root/vidtest.yuv"; drivers/staging/cx25821/cx25821-video-upstream.c: PIXEL_FRMT_411) ? "/root/pal411.yuv" : drivers/staging/cx25821/cx25821-video-upstream.c: "/root/pal422.yuv"; drivers/staging/cx25821/cx25821-video-upstream-ch2.c: PIXEL_FRMT_411) ? "/root/vid411.yuv" : drivers/staging/cx25821/cx25821-video-upstream-ch2.c: "/root/vidtest.yuv"; drivers/staging/cx25821/cx25821-video-upstream-ch2.c: PIXEL_FRMT_411) ? "/root/pal411.yuv" : drivers/staging/cx25821/cx25821-video-upstream-ch2.c: "/root/pal422.yuv"; The driver should not get any file name from userspace, not should read directly to any file. Instead, it should be using V4L2 and ALSA API's for any kind of streams. Please fix it. Cheers, Mauro. Conexant E-mail Firewall (Conexant.Com) made the following annotations --------------------------------------------------------------------- ********************** Legal Disclaimer **************************** "This email may contain confidential and privileged material for the sole use of the intended recipient. Any unauthorized review, use or distribution by others is strictly prohibited. If you have received the message in error, please advise the sender by reply email and delete the message. Thank you." ********************************************************************** --------------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
