On 08/02/2022 04:40, Laurent Pinchart wrote:
Hi Tomi,
Thank you for the patch.
On Mon, Feb 07, 2022 at 06:11:07PM +0200, Tomi Valkeinen wrote:
struct v4l2_subdev_pad_config used to be relevant only for
V4L2_SUBDEV_FORMAT_TRY configuration, and thus the fields of the struct
were named, e.g. try_fmt.
This struct is now used in struct v4l2_subdev_state, and thus can be
used in both try and active cases. Thus rename the fields and drop the
"try_" prefix.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
---
drivers/media/i2c/adv7183.c | 2 +-
drivers/media/i2c/imx274.c | 12 ++++-----
drivers/media/i2c/mt9m001.c | 2 +-
drivers/media/i2c/mt9m111.c | 2 +-
drivers/media/i2c/mt9t112.c | 2 +-
drivers/media/i2c/mt9v011.c | 2 +-
drivers/media/i2c/mt9v111.c | 4 +--
drivers/media/i2c/ov2640.c | 2 +-
drivers/media/i2c/ov6650.c | 18 ++++++-------
drivers/media/i2c/ov772x.c | 2 +-
drivers/media/i2c/ov9640.c | 2 +-
drivers/media/i2c/rj54n1cb0c.c | 2 +-
drivers/media/i2c/saa6752hs.c | 2 +-
drivers/media/i2c/sr030pc30.c | 2 +-
drivers/media/i2c/tw9910.c | 2 +-
drivers/media/i2c/vs6624.c | 2 +-
drivers/media/platform/atmel/atmel-isc-base.c | 8 +++---
drivers/media/platform/atmel/atmel-isi.c | 8 +++---
Would it be possible to move those drivers to use the
v4l2_subdev_get_try_*() helpers instead of accessing the fields directly
? It doesn't necessarily need to be done as part of this series, but
after removing the try_ prefix from the fields it will be more difficult
to identify the offending drivers.
In a separate patch (not part of this series) we should also rename the
v4l2_subdev_get_try_*() functions to v4l2_subdev_state_get_*().
I _knew_ I should not have added this patch, as these only lead to
"could you also..." ;).
Yes, I think it makes sense to use the helpers. And kernel test robot
tells me that I forgot about the staging/
I think I will just drop this one, and go with the helper version
directly. Or rather, first change drivers to use the helper, and then
change the fields.
Tomi
