Hi Jacopo,
Thank you for the patch.
s/is_mipi/ov5640_is_mipi/
On Mon, Jan 31, 2022 at 03:32:27PM +0100, Jacopo Mondi wrote:
> Checking if the sensor is used in DVP or MIPI mode is a repeated
> pattern which is about to be repeated more often.
>
> Provide an inline function to shortcut that.
>
> Signed-off-by: Jacopo Mondi <jacopo@xxxxxxxxxx>
> ---
> drivers/media/i2c/ov5640.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> index 7e7732f30486..fc3e4f61709c 100644
> --- a/drivers/media/i2c/ov5640.c
> +++ b/drivers/media/i2c/ov5640.c
> @@ -310,6 +310,11 @@ static inline struct v4l2_subdev *ctrl_to_sd(struct v4l2_ctrl *ctrl)
> ctrls.handler)->sd;
> }
>
> +static inline bool ov5640_is_mipi(struct ov5640_dev *sensor)
I'd name is ov5640_is_csi2() as MIPI is more than just CSI-2. Up to you.
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> +{
> + return sensor->ep.bus_type == V4L2_MBUS_CSI2_DPHY;
> +}
> +
> /*
> * FIXME: all of these register tables are likely filled with
> * entries that set the register to their power-on default values,
> @@ -1224,7 +1229,7 @@ static int ov5640_load_regs(struct ov5640_dev *sensor,
> /* remain in power down mode for DVP */
> if (regs->reg_addr == OV5640_REG_SYS_CTRL0 &&
> val == OV5640_REG_SYS_CTRL0_SW_PWUP &&
> - sensor->ep.bus_type != V4L2_MBUS_CSI2_DPHY)
> + !ov5640_is_mipi(sensor))
> continue;
>
> if (mask)
> @@ -1859,7 +1864,7 @@ static int ov5640_set_mode(struct ov5640_dev *sensor)
> * the same rate than YUV, so we can just use 16 bpp all the time.
> */
> rate = ov5640_calc_pixel_rate(sensor) * 16;
> - if (sensor->ep.bus_type == V4L2_MBUS_CSI2_DPHY) {
> + if (ov5640_is_mipi(sensor)) {
> rate = rate / sensor->ep.bus.mipi_csi2.num_data_lanes;
> ret = ov5640_set_mipi_pclk(sensor, rate);
> } else {
> @@ -3042,7 +3047,7 @@ static int ov5640_s_stream(struct v4l2_subdev *sd, int enable)
> sensor->pending_fmt_change = false;
> }
>
> - if (sensor->ep.bus_type == V4L2_MBUS_CSI2_DPHY)
> + if (ov5640_is_mipi(sensor))
> ret = ov5640_set_stream_mipi(sensor, enable);
> else
> ret = ov5640_set_stream_dvp(sensor, enable);
--
Regards,
Laurent Pinchart
