Hi Daniel, I love your patch! Perhaps something to improve: [auto build test WARNING on media-tree/master] [also build test WARNING on v5.17-rc2 next-20220131] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Scally/Introduce-ancillary-links/20220131-080041 base: git://linuxtv.org/media_tree.git master reproduce: make htmldocs If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> include/media/media-entity.h:1126: warning: expecting prototype for media_entity_call(). Prototype was for media_create_ancillary_link() instead vim +1126 include/media/media-entity.h 1094 1095 /** 1096 * media_entity_call - Calls a struct media_entity_operations operation on 1097 * an entity 1098 * 1099 * @entity: entity where the @operation will be called 1100 * @operation: type of the operation. Should be the name of a member of 1101 * struct &media_entity_operations. 1102 * 1103 * This helper function will check if @operation is not %NULL. On such case, 1104 * it will issue a call to @operation\(@entity, @args\). 1105 */ 1106 1107 /** 1108 * media_create_ancillary_link() - create an ancillary link between two 1109 * instances of &media_entity 1110 * 1111 * @primary: pointer to the primary &media_entity 1112 * @ancillary: pointer to the ancillary &media_entity 1113 * 1114 * Create an ancillary link between two entities, indicating that they 1115 * represent two connected pieces of hardware that form a single logical unit. 1116 * A typical example is a camera lens being linked to the sensor that it is 1117 * supporting. 1118 * 1119 * The function sets both MEDIA_LNK_FL_ENABLED and MEDIA_LNK_FL_IMMUTABLE for 1120 * the new link. This behaviour may be subject to change in the future, so 1121 * userspace applications using ancillary links should ensure that ancillary 1122 * links are enabled when in use. 1123 */ 1124 struct media_link * 1125 media_create_ancillary_link(struct media_entity *primary, > 1126 struct media_entity *ancillary); 1127 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
