Hi Sakari,
Thank you for the patch.
On Fri, Jan 28, 2022 at 10:33:06AM +0200, Sakari Ailus wrote:
> Remove redundant kerneldoc documentation in mc-device.c. The functions are
> already documented in media-device.h.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> ---
> drivers/media/mc/mc-device.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/drivers/media/mc/mc-device.c b/drivers/media/mc/mc-device.c
> index cf5e459b1d96..094647fdb866 100644
> --- a/drivers/media/mc/mc-device.c
> +++ b/drivers/media/mc/mc-device.c
> @@ -608,11 +608,6 @@ static void __media_device_unregister_entity(struct media_entity *entity)
> entity->graph_obj.mdev = NULL;
> }
>
> -/**
> - * media_device_register_entity - Register an entity with a media device
> - * @mdev: The media device
> - * @entity: The entity
> - */
Looks good.
> int __must_check media_device_register_entity(struct media_device *mdev,
> struct media_entity *entity)
> {
> @@ -691,16 +686,6 @@ void media_device_unregister_entity(struct media_entity *entity)
> }
> EXPORT_SYMBOL_GPL(media_device_unregister_entity);
>
> -/**
> - * media_device_init() - initialize a media device
> - * @mdev: The media device
> - *
> - * The caller is responsible for initializing the media device before
> - * registration. The following fields must be set:
> - *
> - * - dev must point to the parent device
> - * - model must be filled with the device model name
This is not captured in media-device.h. With this fixed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> - */
> void media_device_init(struct media_device *mdev)
> {
> INIT_LIST_HEAD(&mdev->entities);
--
Regards,
Laurent Pinchart
