Re: [PATCH 0/2] staging: media: imx7-mipi-csis: Two small fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rui

On Wed, Jan 19, 2022 at 04:21:15PM +0000, Rui Miguel Silva wrote:
> Hey Jacopo,
> both patches LGTM.
>
> I only have one nit with them...
>
> On Wed Jan 19, 2022 at 11:20 AM WET, Jacopo Mondi wrote:
>
> > Two small fixes for the imx7-mipi-csis driver.
> >
> > The second patch is required to correctly capture in packed YUV422 formats
> >
> > Thanks
> >    j
> >
> > Jacopo Mondi (2):
> >   staging: media: imx: imx7-mipi-csic: Resume on debug
> >   staging: media: imx: imx7-mipi-csic: Set PIXEL_MODE for YUV422
>                                       ^
>                    here should be s (imx7-mipi-csis) on both patches

Oh ups, I honestly thought at the time the IP core was called csic...

>
> Maybe Laurent could fix the typo on the pull, other than that:

I owe an update to add an error check to 1/2 once Laurent (or someone
with an i.MX8MM) tests 2/2, so I can fix the subject in v2.

>
> Acked-by: Rui Miguel Silva <rmfrfs@xxxxxxxxx>

Thanks
   j

>
> Cheers,
>    Rui
>
> >
> >  drivers/staging/media/imx/imx7-mipi-csis.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > --
> > 2.34.1
>
>
>



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux