Hi all, On 12/01/2022 09:57, Neil Armstrong wrote: <snip> > > Then the patches were sent: > - 20211210015620.2143555-1-jiasheng@xxxxxxxxxxx on 10/12/2021 > - 20211215033535.40422-1-zhou1615@xxxxxxx on 15/12/2021 > > They are extremely close but not similar, mostly indenting differs. > > Both patches have the missing final "return 0" in amvdec_add_ts which is missing in my proposal. > > But only 20211210015620.2143555-1-jiasheng@xxxxxxxxxxx has the correct "if (ret)" in esparser_queue(). > Patch 20211215033535.40422-1-zhou1615@xxxxxx has a wrong "if (!ret)". > > But when comparing, 20211215033535.40422-1-zhou1615@xxxxxxx is an almost exact copy of my proposal, minus the fixes and the bogus return check. > > To be honest, there is a limited way to fix this, it's probable 20211215033535.40422-1-zhou1615@xxxxxxx was written independently from > my proposal since there is a bug return check, and 20211210015620.2143555-1-jiasheng@xxxxxxxxxxx was rewritten from my proposal. > > Since 20211215033535.40422-1-zhou1615@xxxxxx has a bogus return check, it should be naked. OK, I had already rejected this, so that remain rejected. > > I'll only ask 20211210015620.2143555-1-jiasheng@xxxxxxxxxxx to be resent with a "Suggested-by" and indentation fixed like my proposal. I changed the status of this patch to 'Changes Requested'. Jiasheng, can you post a v3 with the requested changes? Neil, thank you for your detailed analysis! Regards, Hans
