Hi Hans, On Tue, Jan 11, 2022 at 10:45 AM Hans Verkuil <hverkuil-cisco@xxxxxxxxx> wrote: > > On 11/01/2022 11:43, Lad, Prabhakar wrote: > > Hi Hans, > > > > On Tue, Jan 11, 2022 at 10:25 AM Hans Verkuil <hverkuil-cisco@xxxxxxxxx> wrote: > >> > >> Hi Prabhakar, > >> > >> On 11/01/2022 01:23, Lad Prabhakar wrote: > >>> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static > >>> allocation of IRQ resources in DT core code, this causes an issue > >>> when using hierarchical interrupt domains using "interrupts" property > >>> in the node as this bypasses the hierarchical setup and messes up the > >>> irq chaining. > >>> > >>> In preparation for removal of static setup of IRQ resource from DT core > >>> code use platform_get_irq_optional(). > >>> > >>> While at it, propagate error code in case devm_request_irq() fails > >>> instead of returning -EINVAL in vpif_display.c. > >> > >> Please note that this patch clashes with [1], for which I just posted a PR [2]. > >> > > Ouch, I think I had a comment for patch#2 which needed to be addressed > > (I was nitpicking anyway) so I was hoping this will go in first. > > Patch 2 was fine since that change makes sense when looking at patch 3. > Agreed. > > > >> So once [2] is merged you'll need to rebase this patch. > >> > > Ok, do you want me to just re-send this patch alone or the entire series? > > Either works. > Will just send this alone patch as v3. Cheers, Prabhakar
