On Tue, Jan 11, 2022 at 10:55:47AM +0200, Dafna Hirschfeld wrote: > > > On 11.01.22 10:52, Christoph Hellwig wrote: >> On Tue, Jan 11, 2022 at 10:50:50AM +0200, Dafna Hirschfeld wrote: >>> I'll send v2 with shorter lines. (the official limit is now 100 char which I still follow). >> >> No. It is 80 lines with an exception to go over it if it sigificantly >> improves readability. > > Ok, didn't know that. > >> >>> You mean you would call "invalidate_kernel_vmap_range" before "dma_sync_sgtable_for_cpu" ? >> >> Yes. > > Could you explain why? the vmap range is the one actually use for cpu access and thus most prone for speculation, so I'd invalidate it first. It probably does not matter to much, but that order looks more sensible.
