Hey Bryan,
Thanks for submitting this series.
On Sun, 9 Jan 2022 at 03:47, Bryan O'Donoghue
<bryan.odonoghue@xxxxxxxxxx> wrote:
>
> If we review the schematic for RB3 Thundercomm document Turbox-845 we see
> that the CAMSS CSI PHY has the same basic power-rail layout as UFS, PCIe
> and USB PHYs.
>
> We should therefore have two regulator declarations as is the case for UFS,
> PCIe and USB.
>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: robh@xxxxxxxxxx
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
> .../bindings/media/qcom,sdm845-camss.yaml | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> index 9ca5dfa7f2260..ae0642b9ae5ec 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> @@ -203,9 +203,13 @@ properties:
> - const: vfe1
> - const: vfe_lite
>
> - vdda-supply:
> + vdda-phy-supply:
> description:
> - Definition of the regulator used as analog power supply.
> + Phandle to a regulator supply to PHY core block.
> +
> + vdda-pll-supply:
> + description:
> + Phandle to 1.8V regulator supply to PHY refclk pll block.
>
> required:
> - clock-names
> @@ -217,7 +221,8 @@ required:
> - power-domains
> - reg
> - reg-names
> - - vdda-supply
> + - vdda-phy-supply
> + - vdda-pll-supply
>
> additionalProperties: false
>
> @@ -361,7 +366,8 @@ examples:
> "vfe1",
> "vfe_lite";
>
> - vdda-supply = <®_2v8>;
> + vdda-phy-supply = <&vreg_l1a_0p875>;
> + vdda-pll-supply = <&vreg_l26a_1p2>;
>
> ports {
> #address-cells = <1>;
> --
> 2.33.0
>
The patch looks good to me.
Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx>
