Am Freitag, den 25.06.2010, 01:43 +0200 schrieb hermann pitton: > Hi, Jean-Michel, > > Am Freitag, den 25.06.2010, 00:42 +0200 schrieb Jean-Michel Grimaldi: > > Hi, I have a Terratec Cinergy 250 PCI video card, and a small > > modification in saa7134-cards.c is needed for it to work. I built the > > patch on 2.6.34 version (I sent the modification to the maintainer in > > early 2009 but got no feedback): > > > > -- saa7134-cards.old.c 2010-06-25 00:31:16.000000000 +0200 > > +++ saa7134-cards.new.c 2010-06-25 00:30:52.000000000 +0200 > > @@ -2833,7 +2833,7 @@ > > .tv = 1, > > },{ > > .name = name_svideo, /* NOT tested */ > > - .vmux = 8, > > + .vmux = 3, > > .amux = LINE1, > > }}, > > .radio = { > > > > Thanks for taking it into account in future kernels. > > > > hm, don't know who missed it. After Gerd, the main mover on saa7134 was > Hartmut, also /me and some well known others cared. > > Official maintainer these days is Mauro. > > For latest DVB stuff, you also will meet Mike Krufky. > > I'm sorry, but your patch is still wrong. > > You do have only a Composite signal. S-Video, with separated chroma and > luma, can only be on vmux 5-9. > > NACKED-by: hermann pitton <hermann-pitton@xxxxxxxx> Jean-Michel, do you understand? You need to add the missing Composite inputs instead. One of them can be Composite over the S-Video-in connector. Have a look at other cards in saa7134-cards.c. Cheers, Hermann -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html