Thanks for the feedback already. Do you know which kernel version this
driver is functional in out of the top of your head?
I tried multiple kernels and had no luck getting it to work so far.
On Thu, Jun 24, 2010 at 2:32 PM, Bjørn Mork <bjorn@xxxxxxx> wrote:
> Pascal Hahn <derpassi@xxxxxxxxx> writes:
>
>> I can't see any of the expected mantis_ca_init but couldn't figure out
>> in the code where that gets called.
>
> I don't think it is. It was at some point, but it seems to be removed.
> Most likely because it wasn't considered ready at the time this driver
> was merged(?)
>
> BTW, there is a potentional null dereference in mantis_irq_handler(),
> which will do
>
> ca = mantis->mantis_ca;
> ..
> if (stat & MANTIS_INT_IRQ0) {
> dprintk(MANTIS_DEBUG, 0, "<%s>", label[1]);
> mantis->gpif_status = rst_stat;
> wake_up(&ca->hif_write_wq);
> schedule_work(&ca->hif_evm_work);
> }
>
> This will blow up if (stat & MANTIS_INT_IRQ0) is true, since
> mantis->mantis_ca never is allocated. But then I guess that the
> hardware should normally prevent (stat & MANTIS_INT_IRQ0) from being
> true as long as the ca system isn't initiated, so this does not pose a
> problem in practice.
>
> Still doesn't look good.
>
>
>
> Bjørn
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
