Hi Petko, Quoting Petko Manolov (2022-01-03 11:09:17) > v2: Removes an unused function (ovm6211_set_pix_clk) and this patch series is > now based on media/master; Didn't receive any comments about the RFC version, > thus i assume everything is perfect... :P Did you see https://lore.kernel.org/linux-media/Ya9XHiz%2FPm4CjQ13@xxxxxxxxxxxxxxxxxxxxxx/? Sakari provided quite a few review comments to consider. I don't think we need to add new sensor drivers to the staging directory which would simplify your series quite a bit, and Sakari also stated the ovm6211 KConfig and Makefile entry should be in the patch along with the new driver code (not in staging). So you would need to refactor this series to a single patch adding the driver do drivers/media/i2c/, and a second patch which adds the DT-bindings accordingly. -- Kieran > > This patch adds ovm6211 driver into the staging directory. It also creates > media/i2c entry, where ovm6211.c lives for now, to mimic the generic media > source tree. > > Petko Manolov (5): > adds ovm6211 driver to staging > adds ovm6211 entry to Kconfig > adds ovm6211 entry to Makefile > adds drivers/staging/media/i2c/Kconfig entry > adds i2c/ explicitly to Makefile > > drivers/staging/media/Kconfig | 2 + > drivers/staging/media/Makefile | 1 + > drivers/staging/media/i2c/Kconfig | 9 + > drivers/staging/media/i2c/Makefile | 1 + > drivers/staging/media/i2c/ovm6211.c | 1143 +++++++++++++++++++++++++++ > 5 files changed, 1156 insertions(+) > create mode 100644 drivers/staging/media/i2c/Kconfig > create mode 100644 drivers/staging/media/i2c/Makefile > create mode 100644 drivers/staging/media/i2c/ovm6211.c > > > base-commit: 68b9bcc8a534cd11fe55f8bc82f948aae7d81b3c > -- > 2.30.2 >
