Hi,
On 07/12/2021 01:07, Laurent Pinchart wrote:
Add a new V4L2 subdev driver for the OmniVision OV10633 and OV10635
camera sensors. The work is based on the driver from the TI BSP, itself
based on original work by Phil Edworthy posted to the linux-media
mailing list ([1]). This version of the code is a large rewrite of many
parts.
[1] http://www.spinics.net/lists/linux-media/msg64347.html
Signed-off-by: Nikhil Devshatwar <nikhil.nd@xxxxxx>
Signed-off-by: Benoit Parrot <bparrot@xxxxxx>
Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
---
Changes since v1:
- Drop unneeded debug message
- Fix MODULE_LICENSE
- Fix priv pointer retrieval in remove()
- Add more registers macros
- Fix PLL calculation
- Update to subdev state API
- Fix test pattern when starting streaming
Looks good to me:
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
Jfyi, I tested this on my FPDLink setup. I, of course, needed to add the
multiplexed streams and routing support, but aside that, there are two
things I needed:
- The pclk has to be 96MHz, so I just hardcoded it to 96MHz in the
ov1063x_pll_setup.
- I commented out the writing of the three registers in
ov1063x_configure() under /* Sensor configuration */. If these are
enabled, 96MHz pclk doesn't work for me. I have no idea about this.
Tomi
